Skip to content

Fix regression of renderer #16091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 6, 2021
Merged

Fix regression of renderer #16091

merged 2 commits into from
Jun 6, 2021

Conversation

lunny
Copy link
Member

@lunny lunny commented Jun 6, 2021 •
edited
Loading

Unfortunately, #15175 missed a feature that csv or external renderer could ignore PostProcess to make the render speed up which introduced at #15153. This PR will fix that.

This PR also fixed another bug which external renderers will load twice when settings reload. From https://discord.com/channels/322538954119184384/323701541297192961/851123308321046538 thanks @KN4CK3R

@lunny lunny added issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jun 6, 2021
@lunny lunny added this to the 1.15.0 milestone Jun 6, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 6, 2021
@lunny lunny added the type/bug label Jun 6, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #16091 (24f049d) into main (ee5e1c4) will increase coverage by 0.11%.
The diff coverage is 70.00%.

❗ Current head 24f049d differs from pull request most recent head 99197e2. Consider uploading reports for the commit 99197e2 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16091      +/-   ##
==========================================
+ Coverage   44.06%   44.18%   +0.11%     
==========================================
  Files         683      683              
  Lines       82358    82367       +9     
==========================================
+ Hits        36295    36396     +101     
+ Misses      40176    40071     -105     
- Partials     5887     5900      +13
Impacted Files Coverage Δ
modules/markup/renderer.go 67.00% <70.00%> (-5.53%) ⬇️
modules/git/repo_base_nogogit.go 82.85% <0.00%> (-2.86%) ⬇️
modules/git/utils.go 62.50% <0.00%> (-2.78%) ⬇️
models/error.go 39.84% <0.00%> (+0.31%) ⬆️
services/pull/pull.go 43.37% <0.00%> (+0.45%) ⬆️
routers/api/v1/repo/pull.go 28.74% <0.00%> (+0.59%) ⬆️
modules/markup/markdown/markdown.go 63.43% <0.00%> (+0.74%) ⬆️
models/notification.go 66.07% <0.00%> (+0.88%) ⬆️
modules/queue/unique_queue_disk_channel.go 48.63% <0.00%> (+1.36%) ⬆️
modules/process/manager.go 75.30% <0.00%> (+2.46%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3ef6a6...99197e2. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 6, 2021
@techknowlogick techknowlogick merged commit b6762e2 into go-gitea:main Jun 6, 2021
@lunny lunny deleted the lunny/fix_renderer branch June 7, 2021 01:02
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
@lunny @AbdulrhmnGhanem
Fix regression of renderer (go-gitea#16091)
ec28ac3 
* Fix regression of renderer

* Fix render setting load twice bug
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@KN4CK3R KN4CK3R KN4CK3R approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
7 participants
@lunny @codecov-commenter @lafriks @KN4CK3R @zeripath @techknowlogick @GiteaBot